Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better mstatus when FPU instruction #867

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

YoannPruvost
Copy link
Contributor

When a floating point instruction cause an update of the mstatus csr, this update was not visble on the rvfi trace for non fpu instruction that were completed before the fpu response but are considered retired after.

This workaround updates the mstatus read value for all instructions that are completed before the fpu response but come latter in retire order

@YoannPruvost YoannPruvost added the Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.) label Sep 6, 2023
@YoannPruvost YoannPruvost changed the title Dev rvfi mstatus apu Better mstatus when FPU instruction Sep 6, 2023
new_rvfi_trace.m_csr.mstatus_wmask = 32'hFFFF_FFFF;
s_mstatus_sd_fs_mirror = 32'h0; // Reset mirror
end
// if (s_mstatus_sd_fs_mirror != 32'h0) begin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you delete this piece of code instead of commenting it? you can always find it back in the github history

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done

@davideschiavone davideschiavone merged commit 7e13105 into openhwgroup:dev Sep 6, 2023
1 check passed
@YoannPruvost YoannPruvost deleted the dev_rvfi_mstatus_apu branch October 4, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Verif For issues in the verification environment or test cases (e.g. for testbench, C code, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants